[92] Evaluation: Submission Scoring Completion #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssion-evaluation-view-for-evaluators * 'dev' of github.com:GSA/Challenge_platform: codeclimate [1508] exclude draft submissions from challenge manager views [60] fixes a11y feedback + a typo
…ation-score-calculation * 'dev' of github.com:GSA/Challenge_platform: [345] Evaluation Status (#363)
…ation-score-calculation * 'dev' of github.com:GSA/Challenge_platform: [284] Submission Document Access (#369)
58 tasks
…ation-submission-scoring-completion * 'dev' of github.com:GSA/Challenge_platform: add some spec expectations codeclimate revert db/structure.sql changes remove schema_migration version 20250113162854 remove counter_culture, update user scope update burger layout dynamic additional_action rendering codeclimate [89] submission detail review (#383) 89 | Update submission detail view to incorporate evaluation scoring [71] Evaluation Score Calculation (#375) [368] Add table names (a11y) (#381) rubocop add counter culture gem to perform a counter cache count on active submissions working except for counter cache 89 | Hide Evaluate button if evaluator has recused themselves 89 | Add functionality to open submission materials only in a new tab from submission details 89 | Add phase for back link 89 | Add show route for evaluator submission detail view
…ation-submission-scoring-completion * 'dev' of github.com:GSA/Challenge_platform: [344] Enforce uniqueness of evaluator submission assignments. (#384)
…ation-submission-scoring-completion * 'dev' of github.com:GSA/Challenge_platform: (24 commits) Bump rubocop from 1.70.0 to 1.71.2 (#390) Bump rubocop-rails from 2.28.0 to 2.29.1 Bump selenium-webdriver from 4.27.0 to 4.28.0 (#371) Bump rubocop-performance from 1.23.0 to 1.23.1 (#366) Bump rubocop-rspec from 3.3.0 to 3.4.0 (#374) Bump undici from 6.20.1 to 6.21.1 (#389) Update Accept header codeclimate code climate codeClimate 91 | Remove handle outside click behavior 91 | Update recusal structure for new and existing evaluations fix spec 91 | Update recusal with evaluation scoring changes 89 | Update submission detail view to incorporate evaluation scoring 91 | Update recusal modal to use shared ModalController 91 | Check successful recusal first 91 | Add recusal button/modal to evaluation form in evaluator submission details 91 | Add translations for recusal success/failure 91 | Add functionality to recuse + tests ...
…ation-submission-scoring-completion * 'dev' of github.com:GSA/Challenge_platform: fixes a broken link on evaluator_submission_assignments page (#392)
cpreisinger
force-pushed
the
92/evaluation-submission-scoring-completion
branch
from
ef3ff2a to
865cba7
Compare
stepchud
previously requested changes
Feb 11, 2025
There was a problem hiding this comment.
Save as draft isn't working anymore. It's marking it completed and showing me the completed confirmation message (or showing validation errors if the scores are missing). I think it's because of how the confirmation modal is rendered inside the form and that is adding a hidden mark_complete attribute.
There are some request specs that are supposed to test save_draft behavior but it's not failing.
…ation-submission-scoring-completion * 'dev' of github.com:GSA/Challenge_platform: exclude deleted submissions from evaluator evaluation status counts (#411)
…ation-submission-scoring-completion * 'dev' of github.com:GSA/Challenge_platform: code climate code climate 342 | Extract evaluator and invitation removal into a service 342 | Deletes evaluator submission assignments and evaluation records when evaluator is removed from a challenge phase
|
Draft evaluations are working now. As far as the Service layer goes, I'm not strongly opinionated. The goals for a service object are to reduce complexity in the controller by encapsulating business logic in a separate class. I shared this video with Emma a few months ago. I think it gives a good overview about service objects to help get started. Let's pair on it after the meetings tomorrow and come up with a plan. |
stepchud
reviewed
Feb 13, 2025
stepchud
reviewed
Feb 13, 2025
stepchud
approved these changes
Feb 13, 2025
stepchud
reviewed
Feb 13, 2025
stepchud
reviewed
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#92